Add consistent ?mv={version} cache busting suffix to prevent browser cache issues (part two) #16026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-H
changed the title
Ibochkarev
approved these changes
Feb 2, 2022
|
How do we know it's complete now? 🤷♂️😋 |
|
Well, at least I no longer have any uncommitted changes! 😆 Also:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I somehow missed committing these changes for #16016, so here's part two. 😬
What does it do?
Adds ?mv={version} to registered css and js scripts that are prone to change between releases.
Note I've opted for ?mv instead of ?v because there are extras that already use their own ?v so this reduces the odds of conflicts.
Why is it needed?
Avoid sticky browser caches like https://community.modx.com/t/modx-3-0-0-package-management-processor-not-found/4908
How to test
Confirm correct version string gets added and things still work.
Related issue(s)/PR(s)
#16016