Skip to content

[Port to 3.x] Fix Various Issues with Form Panel Validation and Field Display - Part 3, Snippet Panel #16119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 20, 2022

Conversation

smg6511
Copy link
Collaborator

@smg6511 smg6511 commented Apr 5, 2022

NOTE: This is part 3 of 6 of a revised submission of #15887. This should be reviewed after part 2 is merged (there are two small changes needed from that PR to make the locked switch appear correctly).

What does it do?

Ports enhancements to the Snippet form panel from PR #15146 to 3.x (including subsequent fixes by others).
Changes include:

  1. Updated panel JS to make form layout consistent with the layout introduced in the current TV panel, and utilize new shared methods introduced in the main FormPanel via part 1 of this PR set (already merged).
  2. A handful of minor lexicon updates.

Why is it needed?

Makes needed UI and consistency improvements to the Snippet panel.

How to test

  1. From your terminal app, run grunt build from within the _build/templates/default folder and clear your browser cache.
  2. Create and update a few Snippets to verify behavior and appearance is as expected.

Related issue(s)/PR(s)

Partial port of #15146

@smg6511 smg6511 requested review from opengeek and Mark-H as code owners April 5, 2022 05:56
@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Apr 5, 2022
@smg6511 smg6511 added the pr/review-needed Pull request requires review and testing. label Apr 5, 2022
@smg6511 smg6511 added this to the v3.0.1 milestone Apr 5, 2022
Jim Graham added 5 commits April 16, 2022 23:38
Removed link to code field, as scrolling was not working properly.
Tweak to prevent undefined error when keyup is fired on empty field
@smg6511 smg6511 force-pushed the 3.x-port-pr-15146-rev-part-3 branch from 90db2a3 to 16c6b6f Compare April 17, 2022 03:39
@theboxer
Copy link
Member

theboxer commented Apr 20, 2022

@smg6511 Same issue as on the part for Chunks (#16128 (comment)) happens in snippets view as well. I wonder if the placement of the code copy should be adjusted, or if we'll just ignore the issue, as it happens only in specific case (and in different languages the case will be different)

@opengeek opengeek merged commit b338d75 into modxcms:3.x Apr 20, 2022
@smg6511 smg6511 deleted the 3.x-port-pr-15146-rev-part-3 branch July 19, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR. pr/review-needed Pull request requires review and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants