Exclude @SELECT binding from properties check in MODX 3 #16286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@sdrenth can you help us test this PR? |
Mark-H
approved these changes
Nov 2, 2022
Member
|
This pull request has been mentioned on MODX Community. There might be relevant details there: https://community.modx.com/t/modx-3-0-1-error-if-list-createdby-via-select/5981/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
PR #15488 added a way to add properties to bindings in the form
@SNIPPET someSnippet {"someKey":"someValue"}by looking for a value after the second whitespace and trying to parse this value as a JSON string.Because every
@SELECTbinding contains a lot of whitespace an no JSON, it should be excluded from the check.Why is it needed?
To avoid constant (misleading) error log messages for every
@SELECTbinding.How to test
Create a TV with a
@SELECTbinding in the input option values and verify, that there are no more "third parameter is invalid JSON ..." error log messages.Related issue(s)/PR(s)
Resolves #16200