Skip to content

Fix the query that is generated to purge the old installed extras #16716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from

Conversation

Jako
Copy link
Collaborator

@Jako Jako commented Mar 3, 2025

What does it do?

Fix incorrect DATETIME value: '0000-00-00 00:00:00' error in the query

Why is it needed?

The generated query is wrong for MySQL installations that have NO_ZERO_DATE/NO_ZERO_IN_DATE activated.

Related issue(s)/PR(s)

None known.

@Jako Jako requested review from opengeek and Mark-H as code owners March 3, 2025 10:26
since both conditions have to be filtered
@rthrash rthrash added this to the v2.9.0 milestone Mar 13, 2025
opengeek pushed a commit that referenced this pull request Mar 20, 2025
### What does it do?
Fix incorrect DATETIME value: '0000-00-00 00:00:00' error in the query

### Why is it needed?
The generated query is wrong for MySQL installations that have
NO_ZERO_DATE/NO_ZERO_IN_DATE activated.

### Related issue(s)/PR(s)
MODX 3.x port of #16716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants