Make all JS files editable in the MODX manager in PHP 8.4 #16732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds
application/javascript
to the list of non-binary MIME types.Why is it needed?
In PHP 8.4 some
*.js
files return the MIME typeapplication/javascript
. The same files used to returntext/plain
in previous PHP versions.(I believe
finfo::file
is used in the code to determine the MIME type, but I couldn't figure out what exactly changed in the new PHP version.)How to test
test.js
Related issue(s)/PR(s)
Resolves #16730