Fix Media Browser Sorting by Modification Date #16734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code style fixes, modernization, and optimizations only.
Remove duplicate load listener (with non-dup function). This was added in modxcms#16394. The newer load listener never gets called because it precedes another one.
Add new unmodified date field for sorting purposes only
opengeek
requested changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds raw, unformatted date data into store for use in sorting.
Why is it needed?
Some custom formatted date strings can break proper sorting.
How to test
Open Media Browser and select a folder with several files. When choosing to sort by Last Modified, files should show in descending order (you can only check this by selecting each file and taking note of the date in the right details panel).
Related issue(s)/PR(s)
Resolves #16731