Skip to content

fix(stage-ui-three): OrbitControl initialisation #1877

Merged
Lilia-Chen merged 2 commits into
mainfrom
lilia/fix
May 27, 2026
Merged

fix(stage-ui-three): OrbitControl initialisation #1877
Lilia-Chen merged 2 commits into
mainfrom
lilia/fix

Conversation

@Lilia-Chen

Copy link
Copy Markdown
Contributor

Summary

  • Fix the first Live2D -> VRM switch camera regression where OrbitControls could clamp the camera into the model.
  • Remove the VRM render scale control from the model settings panel.
  • Remove the now-unused settings.vrm.render-scale locale entries.
  • Ignore Godot/.NET bin/ and obj/ build artifacts under engines/stage-tamagotchi-godot.

Root Cause

On the first VRM load, OrbitControls can mount before the VRM bootstrap writes a real modelSize. The previous watcher copied modelSize.z = 0 into minDistance and maxDistance, so later camera updates were clamped onto the target before the bootstrap camera pose finished applying.

Changes

  • Skip OrbitControls distance-bound updates until modelSize.z is finite and non-zero.
  • Keep the render scale runtime state intact, but remove the VRM settings UI entry so it is no longer hot-updated from the panel.
  • Add Godot project ignores for local .NET build output.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name Link
🔭 Waiting for approval For maintainers, approve here

Hey, maintainers, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

@Lilia-Chen Lilia-Chen merged commit 484fb1f into main May 27, 2026
10 checks passed
@Lilia-Chen Lilia-Chen deleted the lilia/fix branch May 27, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant