feat(model-driver-mediapipe): integrate MediaPipe as a motion capture tool#828
Conversation
⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.
Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏 |
Summary of ChangesHello @Lilia-Chen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new experimental package, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a significant new feature: the @proj-airi/mediapipe-workshop package, which integrates MediaPipe for motion capture. The implementation is well-structured, adhering to the functional programming principles and separation of concerns outlined in the AGENTS.md document. The core components, including the engine, backend adapter, and VRM retargeting logic, are thoughtfully designed with a focus on performance and stability. The necessary modifications to the existing stage-ui-three package to support this new functionality are minimal and cleanly implemented via a hook system. I've included a couple of suggestions to enhance code robustness and readability. Overall, this is an excellent and well-executed addition to the project.
| if (!config) | ||
| throw new Error('MediaPipe backend not initialized (call init() first)') | ||
|
|
||
| busy = true |
There was a problem hiding this comment.
https://es-toolkit.dev/reference/promise/Semaphore.html use Semaphore(1) or Mutex for controlling to guard with only one instance / concurrent.
b5eeed4 to
3457825
Compare
sumimakito
left a comment
There was a problem hiding this comment.
Approving as the current code is in a working state, and I’m unsure of the author’s follow-up action. Please feel free to merge it if we agree and decide to revisit these details in the future.
Sorry for the delay. I'm on my holiday, and once I have time, I will:
Let's do it step by step. Such that there won't be too much in one PR to do and to review. Furthermore, if someone wants to step in and take over this thread of work, then it would be a more flexible way to collaborate, in my opinion. |
5bbbe53 to
d6d25a5
Compare
…tall; organize asset paths; reuse more types
1ebf2e9 to
f981e20
Compare
ed5b047 to
1c92e5a
Compare
|
Updates to address review notes:
|
|
Kind of laggy. |
Co-authored-by: Makito <5277268+sumimakito@users.noreply.github.com>
Description
Add
@proj-airi/mediapipe-workshop: a MediaPipe mocap workshop package + a devtools playgroundNew workspace package:
packages/mediapipe-workshop(@proj-airi/mediapipe-workshop)PerceptionState) for stage-side consumptionsrc/three/functional pose→VRM retargeting PoC (bone targets + stability heuristics)New Stage Web devtools page:
apps/stage-web/src/pages/devtools/mediapipe-workshop.vueDesign notes
backends/*: MediaPipe-specific initialization + inferenceengine: scheduling, frame dropping, unifiedPerceptionStatethree/*: all new retargeting logic lives here (functional-first)stage-ui-three: only a small per-frame hook surface so the workshop can drive VRM without extending core renderer behaviour.Next steps