fix(nix): don't use /dev/tty in hash update actions#836
Conversation
It doesn't exist (anymore) in the environment of github actions
Summary of ChangesHello @Weathercold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical compatibility problem within GitHub Actions by modifying the Nix hash update scripts. Previously, these scripts relied on Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.
Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏 |
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where the hash update scripts were using /dev/tty, which is not available in GitHub Actions environments. The fix replaces this with a temporary file to capture build output. While this solves the immediate problem, my review points out that this new approach introduces a resource leak by not cleaning up the temporary file, and also changes the format of the hash file by adding a newline, which is likely to break the Nix build. I've provided suggestions for both scripts to use a more robust and idiomatic shell pipeline that avoids temporary files and preserves the correct hash format.
It doesn't exist (anymore) in the environment of github actions
Description
Linked Issues
Additional Context