Skip to content

fix(stage-*): beat sync worklet failed to import modules#839

Merged
nekomeowww merged 2 commits into
mainfrom
fix/beat-sync
Dec 28, 2025
Merged

fix(stage-*): beat sync worklet failed to import modules#839
nekomeowww merged 2 commits into
mainfrom
fix/beat-sync

Conversation

@sumimakito
Copy link
Copy Markdown
Member

@sumimakito sumimakito commented Dec 28, 2025

This pull request updates @nekopaw/tempora to v0.4.0-alpha.1.

This version fixes a bug where the AudioWorklet entry failed to import a module, causing BeatSync to fail to work on Windows. While specifically reported on Windows, this fix likely resolves similar issues on other platforms. By inlining all imports directly into the entry file, the worklet no longer requires importing external files other than the entry file itself.

Fixes AIRI-85

Verified on Windows

Screenshot 2025-12-29 at 3 47 33

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @sumimakito, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue preventing the BeatSync functionality from operating correctly, particularly on Windows, due to AudioWorklet module import failures. It resolves this by upgrading the @nekopaw/tempora package and refactoring how its modules are handled within the worklet, ensuring all necessary code is inlined. This change streamlines the module loading process for the AudioWorklet, enhancing stability and cross-platform compatibility for beat synchronization features.

Highlights

  • Dependency Update: The @nekopaw/tempora package has been updated to v0.4.0-alpha.1 across the project.
  • Beat Sync Fix: This update resolves a critical bug where the AudioWorklet entry for BeatSync failed to import necessary modules, particularly affecting Windows users and potentially other platforms.
  • Module Loading Refactor: The fix involves inlining all required imports directly into the AudioWorklet entry file, eliminating external module dependencies for the worklet and improving its reliability.
  • Dependency Management: Adjustments were made to package.json files across various stage-* applications and packages, either removing @nekopaw/tempora as a direct dependency or updating its reference to use the catalog.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 28, 2025

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name Link
🔭 Waiting for approval For maintainers, approve here

Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @nekopaw/tempora dependency to version 0.4.0-alpha.1 to resolve a bug with module imports in the beat sync AudioWorklet. The changes are primarily in dependency management files, centralizing the version in pnpm-workspace.yaml and adjusting its location in various package.json files. The dependency has been moved to devDependencies where appropriate, which aligns with the description that the new version of the library inlines its assets, making it a build-time dependency. The changes appear correct and consistent with the goal of the pull request.

@nekomeowww nekomeowww merged commit 72010b6 into main Dec 28, 2025
9 checks passed
@nekomeowww nekomeowww deleted the fix/beat-sync branch December 28, 2025 19:33
@sumimakito
Copy link
Copy Markdown
Member Author

@nekomeowww Fix verified in v0.8.0-beta.9 on Windows. Thanks for the prompt release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants