fix(stage-*): beat sync worklet failed to import modules#839
Conversation
Summary of ChangesHello @sumimakito, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue preventing the BeatSync functionality from operating correctly, particularly on Windows, due to AudioWorklet module import failures. It resolves this by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.
Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏 |
There was a problem hiding this comment.
Code Review
This pull request updates the @nekopaw/tempora dependency to version 0.4.0-alpha.1 to resolve a bug with module imports in the beat sync AudioWorklet. The changes are primarily in dependency management files, centralizing the version in pnpm-workspace.yaml and adjusting its location in various package.json files. The dependency has been moved to devDependencies where appropriate, which aligns with the description that the new version of the library inlines its assets, making it a build-time dependency. The changes appear correct and consistent with the goal of the pull request.
|
@nekomeowww Fix verified in v0.8.0-beta.9 on Windows. Thanks for the prompt release. |
This pull request updates
@nekopaw/temporato v0.4.0-alpha.1.This version fixes a bug where the AudioWorklet entry failed to import a module, causing BeatSync to fail to work on Windows. While specifically reported on Windows, this fix likely resolves similar issues on other platforms. By inlining all imports directly into the entry file, the worklet no longer requires importing external files other than the entry file itself.
Fixes AIRI-85
Verified on Windows