feat(adapters): align channel adapter with RFC 1#20
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aligns the Eventa.Adapters.Channels transport behavior with RFC 1, focusing on deterministic terminal handling and clearer outbound-send semantics under terminal states vs. transient outbound pressure.
Changes:
- Update channel adapter send path to fail fast on transient outbound pressure while preserving original channel-writer failure exceptions when terminal.
- Adjust endpoint termination to respect
CompleteOutboundOnDisposefor remote close/fault and harden cancellation races during termination. - Expand/refresh channel adapter tests to cover deterministic ordering (invoke/stream faults vs. closed event), writer-failure propagation, and disposal races; update docs to reflect adapter/AOT posture.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Eventa.Adapters.Tests/Channels/ChannelPipeTests.cs | Adds/updates tests for RFC-1 terminal ordering, fail-fast behavior, and exception-shape preservation. |
| src/Eventa/Support/AsyncSignalQueue.cs | Switches channel options to allow synchronous continuations (behavioral change). |
| src/Eventa.Adapters/Channels/ChannelMessages.cs | Makes ChannelMessage.Envelope non-nullable (tightens contract). |
| src/Eventa.Adapters/Channels/ChannelEndpoint.cs | Uses CompleteOutboundOnDispose for inbound close/fault termination and hardens CTS cancellation against disposal races. |
| src/Eventa.Adapters/Channels/ChannelAdapter.cs | Implements non-blocking send probing to distinguish transient backpressure from terminal writer state; preserves writer exception shapes. |
| README.md | Documents adapter/AOT characteristics and clarifies channel adapter constraints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation