Skip to content

fix: pre import before dev#32

Merged
LemonNekoGH merged 1 commit into
mainfrom
lemonnekogh/pre-import-before-dev
Jun 14, 2026
Merged

fix: pre import before dev#32
LemonNekoGH merged 1 commit into
mainfrom
lemonnekogh/pre-import-before-dev

Conversation

@LemonNekoGH

Copy link
Copy Markdown
Member

No description provided.

@LemonNekoGH LemonNekoGH requested a review from Copilot June 14, 2026 03:27
@LemonNekoGH LemonNekoGH self-assigned this Jun 14, 2026
@LemonNekoGH LemonNekoGH added bug Something isn't working codex labels Jun 14, 2026
@LemonNekoGH LemonNekoGH enabled auto-merge (squash) June 14, 2026 03:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CLI package’s TypeScript ESM import strategy (explicit .ts extensions) and adds a “pre-import” step to the kirie dev flow so Godot imports the project before launching the dev session. It also refactors the runDev tests to use a real example project fixture and to assert the new import invocation.

Changes:

  • Enable TypeScript imports with .ts extensions and update internal imports/exports accordingly.
  • Add prepareGodotProject() to run godot --headless --import before launching Godot in runDev().
  • Improve dev tests by copying a real example project into a temp workspace and using a reusable fake Godot capture script.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/cli/tsconfig.json Enables allowImportingTsExtensions to support explicit .ts ESM specifiers.
packages/cli/test-fixtures/fake-godot.js Adds a reusable fake Godot script to record invocations for tests.
packages/cli/src/vite.ts Updates internal type import to include .ts extension.
packages/cli/src/vite-raw.d.ts Adds typing for Vite/Vitest ?raw imports used by tests.
packages/cli/src/test-project.ts Introduces helper to copy the example CLI project into a temp directory for tests.
packages/cli/src/index.ts Updates public exports to include .ts extensions.
packages/cli/src/godot.ts Adds prepareGodotProject() and updates imports to .ts.
packages/cli/src/dev.ts Runs the new Godot import step before launching Godot.
packages/cli/src/dev.test.ts Refactors tests to use the example project + validates the import + launch invocations.
packages/cli/src/cli.ts Updates runDev import to include .ts extension.
docs/architecture.md Clarifies future scope around export/build workflow.
AGENTS.md Documents the new examples/basic-kirie-cli example and updates CLI v1 scope wording.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +5 to +8
const basicKirieCliExample = fileURLToPath(
import.meta.resolve("../../../examples/basic-kirie-cli"),
);
const repositoryTmpDir = fileURLToPath(import.meta.resolve("../../../.tmp"));
Comment on lines +18 to +22
await fs.symlink(
path.join(basicKirieCliExample, "node_modules"),
path.join(project, "node_modules"),
"dir",
);
@LemonNekoGH LemonNekoGH merged commit 8597e70 into main Jun 14, 2026
11 checks passed
@LemonNekoGH LemonNekoGH deleted the lemonnekogh/pre-import-before-dev branch June 14, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants