Skip to content

Update ass dependency to allow v1.x - #74

Merged
moi15moi merged 1 commit into
moi15moi:mainfrom
vinnpinn:main
Sep 30, 2025
Merged

Update ass dependency to allow v1.x#74
moi15moi merged 1 commit into
moi15moi:mainfrom
vinnpinn:main

Conversation

@vinnpinn

Copy link
Copy Markdown
Contributor

Updates the ass dependency constraint from <1 to >=1.0.0, <2.

The ASS v1.0.0 release contained no code changes, only dropped support for Python <3.8. Tests pass as expected.

Copilot AI review requested due to automatic review settings September 30, 2025 08:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the ASS library dependency constraint to allow version 1.x releases while maintaining compatibility.

  • Updates dependency constraint from < 1 to >=1.0.0, < 2

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread pyproject.toml
requires-python = ">=3.9"
dependencies = [
"ass < 1",
"ass>=1.0.0, < 2",

Copilot AI Sep 30, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The version constraint should include a space after the comma for consistency with the formatting used in other dependencies in this file (e.g., line 14: fontTools>=4.55.0, < 5).

Copilot uses AI. Check for mistakes.
@codecov-commenter

codecov-commenter commented Sep 30, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.57%. Comparing base (4894535) to head (21c3da7).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files          35       35           
  Lines        1640     1640           
=======================================
  Hits         1551     1551           
  Misses         89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moi15moi
moi15moi merged commit a7c4d2f into moi15moi:main Sep 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants