Skip to content

Add mkvfontvalidator - #82

Merged
moi15moi merged 1 commit into
mainfrom
Add-mkvfontvalidator
Oct 26, 2025
Merged

Add mkvfontvalidator#82
moi15moi merged 1 commit into
mainfrom
Add-mkvfontvalidator

Conversation

@moi15moi

@moi15moi moi15moi commented Oct 12, 2025

Copy link
Copy Markdown
Owner

Close #49

Breaking changes:

  • Mkvpropedit.delete_fonts_of_mkv have been renamed Mkvpropedit.delete_all_fonts_of_mkv
  • Mkvpropedit.path doesn't exist anymore. Now, use MKVUtils.MKVTOOLNIX_FOLDER to set the folder of mkvtoolnix.
  • Mkvpropedit class have been renamed MKVPropedit.

@codecov-commenter

codecov-commenter commented Oct 12, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 87.79343% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.10%. Comparing base (a226591) to head (ec656db).

Files with missing lines Patch % Lines
font_collector/mkvtoolnix/mkv_utils.py 67.24% 19 Missing ⚠️
font_collector/mkvtoolnix/mkvpropedit.py 95.23% 2 Missing ⚠️
font_collector/__init__.py 66.66% 1 Missing ⚠️
font_collector/mkvtoolnix/mkv_ass_file.py 90.00% 1 Missing ⚠️
font_collector/mkvtoolnix/mkv_font_file.py 88.88% 1 Missing ⚠️
font_collector/mkvtoolnix/mkvextract.py 97.77% 1 Missing ⚠️
font_collector/mkvtoolnix/mkvmerge.py 96.96% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   94.57%   94.10%   -0.47%     
==========================================
  Files          35       42       +7     
  Lines        1640     1798     +158     
==========================================
+ Hits         1551     1692     +141     
- Misses         89      106      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moi15moi
moi15moi force-pushed the Add-mkvfontvalidator branch 3 times, most recently from 774c18e to 795cf3a Compare October 12, 2025 19:41
Comment thread font_collector/mkvfontvalidator.py Outdated
@moi15moi
moi15moi force-pushed the Add-mkvfontvalidator branch 3 times, most recently from cf400f1 to 1c9a16f Compare October 13, 2025 01:31
Comment thread font_collector/mkvfontvalidator.py
Comment thread font_collector/mkvtoolnix/mkvextract.py Outdated
Comment thread font_collector/mkvfontvalidator.py
@moi15moi
moi15moi force-pushed the Add-mkvfontvalidator branch 3 times, most recently from d524ffe to 9681bf4 Compare October 13, 2025 14:45
Comment thread font_collector/mkvtoolnix/mkvpropedit.py Outdated
Comment thread font_collector/mkvtoolnix/mkvextract.py Outdated
Comment on lines +79 to +85
if (
attachment["content_type"] in MKVUtils.FONT_MIME_TYPE or
(
attachment["content_type"] == "application/octet-stream" and
attachment["file_name"].lower().endswith((".ttf", ".otf", ".ttc", ".otc"))
)
):

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or if the attachment mime type is application/octet-stream and the file extension is ttf, otf, ttc or otc.

So in brief, no one does the same things.
I decided to respect the spec + to add application/x-font-otf which isn't in the spec, but will be one day

@moi15moi
moi15moi force-pushed the Add-mkvfontvalidator branch 2 times, most recently from 82c9601 to 17b75c7 Compare October 15, 2025 00:34
Comment thread font_collector/mkvtoolnix/mkvpropedit.py Outdated
@moi15moi
moi15moi force-pushed the Add-mkvfontvalidator branch from 17b75c7 to 2bbab28 Compare October 16, 2025 23:14
Close #49

Breaking changes:
- Mkvpropedit.delete_fonts_of_mkv have been renamed Mkvpropedit.delete_all_fonts_of_mkv
- Mkvpropedit.path doesn't exist anymore. Now, use MKVUtils.MKVTOOLNIX_FOLDER to set the folder of mkvtoolnix.
- Mkvpropedit class have been renamed MKVPropedit.
@moi15moi
moi15moi force-pushed the Add-mkvfontvalidator branch from 2bbab28 to ec656db Compare October 16, 2025 23:21
@moi15moi
moi15moi marked this pull request as ready for review October 17, 2025 00:02
@moi15moi
moi15moi merged commit 661f009 into main Oct 26, 2025
15 checks passed
@moi15moi
moi15moi deleted the Add-mkvfontvalidator branch October 26, 2025 01:56
moi15moi added a commit that referenced this pull request Dec 26, 2025
Without this, the file logger doesn't register all the log.
Fix #88
Introduced in #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mkvfontvalidator

2 participants