Skip to content

Conversation

@roland-ruedenauer
Copy link
Contributor

Fixes two issues we currently have with saving user settings

  • validation error message getting lost when saving user settings (caused by a client reload call made even if errors were present)
  • avoid displaying the same flash messages twice (XHR case: the client code is fully responsible dealing with flash messages)

@UlrichB22
Copy link
Collaborator

UlrichB22 commented Nov 26, 2025

I checked the Usersettings view and the User CSS URL in the tab Appearence. When entering "@wrong.css",
it now shows the applied value in red and the error message.

The next problem is the size and location of the message, which is not optimal.

image

@roland-ruedenauer
Copy link
Contributor Author

Thanks for testing this.

The latest commit tries to improve upon what you've shown above. Please note that I didn't check interference with other themes. Further UI improvements should probably handled in a separate merge request.

image

@roland-ruedenauer roland-ruedenauer marked this pull request as ready for review November 27, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants