Skip to content

Conversation

@tw-sithumyo
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2023

CLA assistant check
All committers have signed the CLA.

@elnyry-sam-k
Copy link
Member

@tw-sithumyo couple of comments:

  1. Seeds are typically loaded based on enum values in the Mojaloop API specification. In this case, for PartyIdType, enum values here: https://docs.mojaloop.io/api/fspiop/v1.1/api-definition.html#partyidtype-enum . If the new "MERCHANT_PAYINTOID" enum can be an ALIAS as the description says, then please continue using that Enum value.

If however, you need this as a new Enum value, the specification has to be updated first. Please fill in the change request here: https://github.com/mojaloop/mojaloop-specification/issues/new/choose and raise a request with the FSPIOP SIG, led by @henrka .

  1. Please address the CI step failures..

Copy link
Member

@elnyry-sam-k elnyry-sam-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the comments provided on the PR

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants