Skip to content

Conversation

@vijayg10
Copy link
Contributor

No description provided.

@vijayg10 vijayg10 self-assigned this Mar 11, 2025
@sonarqubecloud
Copy link

@kalinkrustev kalinkrustev requested a review from Copilot March 13, 2025 08:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request aligns audit configurations across multiple services by introducing a centralized configuration override and updating application versioning in Helm charts and image tags. Key changes include the addition of a new "configOverride" block in values-mojaloop-iso20022.yaml, the inclusion of Kafka topic definitions in values-backend.yaml, and synchronized version bumps across Helm chart and values files.

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.

File Description
local-deployment-methods/helmfile/values-mojaloop-iso20022.yaml Added centralized audit and Kafka logging configuration via configOverride
local-deployment-methods/helmfile/values-backend.yaml Introduced Kafka topic definitions for audit, log, and trace events
account-lookup-service/, ml-api-adapter/, bulk-api-adapter/* Updated appVersion and image tag values to align with the audit changes
Comments suppressed due to low confidence (1)

local-deployment-methods/helmfile/values-mojaloop-iso20022.yaml:33

  • YAML keys containing periods (e.g. client.id) can be misinterpreted by some parsers; consider quoting these keys (e.g. "client.id") to ensure consistent parsing.
                  client.id: producer-event-audit

Copy link
Contributor

@kalinkrustev kalinkrustev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, still needs a code owner review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants