fix: ttk backend config files not copied properly #748
Conversation
shashi165
requested review from
bushjames,
elnyry-sam-k,
gibaros,
kalinkrustev,
kleyow,
oderayi and
vijayg10
as code owners
shashi165
changed the title
| if echo "$CONTENT" | grep -q '^"http'; then | ||
| URL=$(echo "$CONTENT" | tr -d '"') | ||
| echo "Downloading $URL to $DEST" | ||
| wget -q -O "$DEST" "$URL" |
There was a problem hiding this comment.
Please note that recent version of TTK backend can download the config files on its own, so there is no need this to happen in the chart. We are trying to run all containers with read only file system to improve security and ensure stateless services.
See mojaloop/ml-testing-toolkit#332
There was a problem hiding this comment.
hi @kalinkrustev are there any config changes required for this to work? At what stage it downloads the files? If the root filesystem is readonly will the download work? The current mojaloop/values.yaml in the helm repo doesn't work with your latest change. The files are not downloaded.
There was a problem hiding this comment.
I think you only need to include the new TTK backend image version in helm. The downloaded config is cached in memory and used directly and not saved to the disk.
There was a problem hiding this comment.
Additional PR to implement downloading mojaloop/ml-testing-toolkit#336
|
No description provided.