feat: make build and start commands to be able to use node 17 and higher #161
Conversation
ruirochawork
commented
Jan 17, 2023
ruirochawork
commented
- added --openssl-legacy-provider to start and build commands to be able to use node 17 and higher
- tried fixing it by upgrading react-scripts and its peer dependencies but there were a few breaking changes that required ejecting the app or adding some sort of a wrapper, so added this flag for now (should be look at as a temporary solution)
…e to use node 17 and higher
ruirochawork
requested review from
vijayg10,
mdebarros,
elnyry-sam-k and
kleyow
as code owners
ruirochawork
changed the title
| @@ -277,10 +277,10 @@ jobs: | |||
| name: Build Docker local image | |||
| command: | | |||
| echo "Building Docker image: local" | |||
| docker build -t $DOCKER_ORG/$CIRCLE_PROJECT_REPONAME:local . | |||
There was a problem hiding this comment.
Hi @ruirochawork , I am not sure why you want too replace the variable names with hardcoded values. But we have a standard for circleCI config file across all the mojaloop repositories
There was a problem hiding this comment.
Hi @vijayg10 , I was just testing out on why the docker build is failing. Seems like it might be an issue with populating some kind of environment variable, hence why I changed the state of the PR to draft until I figure out what it is.
#!/bin/bash -eo pipefail
echo "Building Docker image: local"
docker build -t $DOCKER_ORG/$CIRCLE_PROJECT_REPONAME:local .
Building Docker image: local
invalid argument "/ml-testing-toolkit-ui:local" for "-t, --tag" flag: invalid reference format
See 'docker build --help'.
Exited with code exit status 125
CircleCI received exit code 125
Do you happen to know what the problem might be? Would appreciate if you or someone else could help me with this issue since in the other PR it seems to have solved the problem by directly placing the value.
https://app.circleci.com/pipelines/github/mojaloop/ml-testing-toolkit-ui/679
