fix #53 wrong response code on overzoom requests#54
Open
ramunasd wants to merge 1 commit intomojodna:masterfrom
Open
fix #53 wrong response code on overzoom requests#54ramunasd wants to merge 1 commit intomojodna:masterfrom
ramunasd wants to merge 1 commit intomojodna:masterfrom
Conversation
…functional tests
Owner
|
I'm a little backed up, so it may be a few days before I can fully review this. Can you summarize the changes, specifically how this changes behavior? Thanks! |
Contributor
Author
|
Well, the main idea is to add additional argument to getTile callback function. This argument is http status code, which must be returned. So now http status code is determined in one place, during request validation and getTile callback just sends everything as it gets :) |
Contributor
Author
|
Hi @mojodna would be nice to get Your feedback ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this also introduces functional tests, based on mocha