Add IT using custom plugin repository #497
Conversation
| def buildLogText = buildLog.getText() | ||
| // Should have downloaded artifact from custom repository, not from Central | ||
| // (requires running `mvn clean ...`) | ||
| assert buildLogText.contains('Downloaded from google: https://maven.google.com/com/android/tools/r8/2.0.98/r8-2.0.98.jar') |
There was a problem hiding this comment.
Is testing for the "Downloaded from ..." message here ok, or is that too brittle (e.g. when users don't run mvn clean ... or when this Maven message changes)?
There was a problem hiding this comment.
It can occurs not every time ... when artifact will be cached in local repository we will not have such message
Next issue when we have a version in assertions, we will need update test when artifact will update
There was a problem hiding this comment.
But for the integration tests it uses a separate local Maven repository (under target), right? And that is cleaned when running mvn clean ....
There was a problem hiding this comment.
Have removed the check now. You are right, caching seems to be an issue with the current CI setup here.
|
I will try steps as:
as idea to check |
|
I will go with release a fix version, we can work on test later |
Marcono1234
force-pushed
the
custom-plugin-repo-test
branch
from
7262c0d to
f1417d3
Compare
|
Have changed this IT now to use a custom local repository as you suggested. I hope that is what you had in mind. If not, please let me know, or feel free to close this PR. To demonstrate that the bug fix on |
| <id>custom-repo</id> | ||
| <!-- Note: On Windows using `project.basedir` includes backslashes in this URI, which is not ideal | ||
| but seems to work --> | ||
| <url>file:///${project.basedir}/custom-repo</url> |
There was a problem hiding this comment.
For example, this leads to something like (note the \ in the path):
[INFO] Downloading from custom-repo: file:///C:\Users\...
I think technically this is not a valid file: URI, but it seems Maven / Java seems to accept it nonetheless.
Not sure how this can be easily solved. Using file:///./custom-repo did not seem to work, maybe because the working directory is actually in one of its parent dirs (or something was wrong with my test setup)?
|
@slawekjaranowski, what do you think about these changes? |
2 participants
Depends on #496
Adds an integration test which uses a custom plugin repository.