Skip to content

Ignore automatically module-info.class when maxJdkVersion < 1.9#76

Merged
batmat merged 1 commit intomojohaus:masterfrom
Vlatombe:ignore_module_info_before_jdk_9
Mar 29, 2019
Merged

Ignore automatically module-info.class when maxJdkVersion < 1.9#76
batmat merged 1 commit intomojohaus:masterfrom
Vlatombe:ignore_module_info_before_jdk_9

Conversation

@Vlatombe
Copy link
Copy Markdown
Contributor

Context: #46, #36, #75

Fix from #36 would cause unnecessary noise such as

[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53

This supercedes #75.

This fix takes a different approach: when maxJdkVersion < 1.9, module-info is just ignored automatically.

Copy link
Copy Markdown
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batmat batmat self-assigned this Mar 20, 2019
@batmat batmat requested a review from khmarbaise March 20, 2019 13:25
@batmat batmat merged commit d5bcf7e into mojohaus:master Mar 29, 2019
@batmat
Copy link
Copy Markdown
Member

batmat commented Apr 2, 2019

released as 1.2 in staging, vote in progress since a few minutes ago.

Will publish to Central in 72 hours w/o pushback.

@batmat
Copy link
Copy Markdown
Member

batmat commented Apr 2, 2019

@Vlatombe
Copy link
Copy Markdown
Contributor Author

Vlatombe commented Apr 2, 2019

Cool, thanks @batmat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants