psgi env: fix double encoding of path parts #2239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix double encoding of path parts when parsing a PSGI env with a SCRIPT_NAME set.
kraih
reviewed
Mar 31, 2025
| @@ -197,6 +197,8 @@ sub _parse_env { | |||
| $base->path->parse($value =~ m!/$! ? $value : "$value/"); | |||
|
|
|||
| # Remove SCRIPT_NAME prefix if necessary | |||
| # Make sure $path is decoded and unescaped as expected by to_string | |||
There was a problem hiding this comment.
Reads like you're putting things that should be in a nice detailed commit message into comments.
kraih
reviewed
Mar 31, 2025
| # test $env is a stripped down version of the result of: | ||
| # use HTTP::Request::Common 'GET'; | ||
| # use HTTP::Message::PSGI 'req_to_psgi'; | ||
| # $env = req_to_psgi( GET( 'http://www.example.com'.$script_name.$path ), SCRIPT_NAME => $script_name ); |
There was a problem hiding this comment.
Same here, this is ok in a commit message, but serves no real purpose in a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix double encoding of path parts when parsing a PSGI env with a
SCRIPT_NAMEset.