Conversation
- Update CircleCI Docker image from circleci/node:8.11 to cimg/node:20.18 - Add engines field to package.json requiring Node >=20.0.0 - Normalize indentation in CircleCI config Addresses code review findings for Node.js 20 upgrade
- Replace @emotion/core with @emotion/react - Replace emotion-theming with @emotion/react (ThemeProvider now in @emotion/react) - Update peer dependencies to Emotion v11 - Add @emotion/react theme augmentation for type safety - Update webpack externals to include Emotion dependencies - Update tsconfig with jsxImportSource for Emotion - Fix styled component typing for Emotion v11 - Update README installation instructions - Resolves React 18 type compatibility (410+ errors -> 0 errors in src/)
- Configure ts-loader to use tsconfig.build.json - Create tsconfig.build.json that only includes src/ - Prevents webpack from trying to build story files that use deprecated storiesOf API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.