#475: Add phoenix_ecto as explicit dependency #508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #475 by adding
phoenix_ecto
as an explicit dependency in themix.exs
file and updating the README to include it in the requirements section.Problem
Torch uses functionality from
phoenix_ecto
(specifically thePhoenix.HTML.FormData
protocol implementation forEcto.Changeset
) but doesn't declare it as a dependency. This causes errors when users try to use Torch in a Phoenix project that uses Ecto but doesn't explicitly includephoenix_ecto
.The error manifests as:
Solution
{:phoenix_ecto, "~> 4.6"}
to the dependencies inmix.exs
This ensures that Torch explicitly depends on all the libraries it needs to function properly.
💻 View my work • About Codegen