Skip to content

fix: skip ephemeral volume topology requirements for bound pods during consolidation - #1

Closed
moko-poi wants to merge 1 commit into
mainfrom
fix/ephemeral-volume-consolidation-tsc
Closed

fix: skip ephemeral volume topology requirements for bound pods during consolidation#1
moko-poi wants to merge 1 commit into
mainfrom
fix/ephemeral-volume-consolidation-tsc

Conversation

@moko-poi

Copy link
Copy Markdown
Owner

Summary

  • Fix for kubernetes-sigs/karpenter#2803: Ephemeral volumes with zone TopologySpreadConstraints block consolidation with Unconsolidatable events
  • Skip ephemeral volume topology requirements when evaluating bound pods for consolidation, since ephemeral PVCs are deleted with the pod and a new PVC will be created on rescheduling
  • Add unit tests for VolumeTopology.GetRequirements() covering bound/unbound pods with ephemeral/regular volumes
  • Add consolidation integration test verifying replacement succeeds with ephemeral volumes and zone TSC

Test plan

  • Unit tests: bound pod + ephemeral volume returns no topology requirements
  • Unit tests: unbound pod + ephemeral volume returns topology requirements (unchanged behavior)
  • Unit tests: bound pod + regular PVC returns topology requirements (unchanged behavior)
  • Integration test: consolidation replaces node with ephemeral volumes and zone TSC
  • Full scheduling test suite passes (339 tests)
  • Full disruption test suite passes (233 tests)

@moko-poi
moko-poi force-pushed the fix/ephemeral-volume-consolidation-tsc branch from 01a28a7 to 9ee5051 Compare March 11, 2026 09:25
@moko-poi moko-poi closed this Mar 11, 2026
@coveralls

coveralls commented Mar 11, 2026

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 22945641385

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 80.291%

Totals Coverage Status
Change from base Build 22943509809: 0.009%
Covered Lines: 12087
Relevant Lines: 15054

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants