fix: address credential logging, cert validation, arg injection, and port race#299
Closed
0xjustBen wants to merge 1 commit into
Closed
fix: address credential logging, cert validation, arg injection, and port race#2990xjustBen wants to merge 1 commit into
0xjustBen wants to merge 1 commit into
Conversation
…g, and arg parsing - Validate downloaded proxy certificate matches expected domain before use - Delete and re-fetch cached certificate if domain validation fails - Redact Riot auth tokens, entitlement JWTs, and PAS JWTs from debug logs - Minimise TOCTOU window on config proxy port binding - Block --client-config-url injection via riotClientParams to prevent proxy bypass - Validate GitHub release URL starts with https://github.com/ before opening - Add Persistence.DeleteCachedCertificate() helper for invalid cert cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #297
Changes
Utils.csdeceive-localhost.molenzwiebel.xyz(CN or SAN) before usehtml_urlstarts withhttps://github.com/before passing toProcess.StartValidateProxyCertificate()helperConfigProxy.csTcpListenerimmediately beforeWebServerbinds rather than before setup beginsStartupHandler.csriotClientParamscontaining--client-config-urlto prevent proxy bypass via arg injectionPersistence.csDeleteCachedCertificate()used when cached cert fails domain validationTest plan
debug.logno longer contains auth header values or PAS JWT contentriotClientParamswith--client-config-urlis ignored (logged warning instead)