feat(directory-client): fill in FDP-related fields during publishing#5797
Merged
feat(directory-client): fill in FDP-related fields during publishing#5797
Conversation
|
…ariable 'username' on UNIX systems
YpeZ
approved these changes
Mar 11, 2026
Contributor
YpeZ
left a comment
YpeZ
left a comment
There was a problem hiding this comment.
Tests work. Examples work as well
|
connoratrug
pushed a commit
that referenced
this pull request
Mar 12, 2026
…5797) * Add endpoint table * Add Agent table * Add Catalog table * Cleaned up and ordered Catalog.csv to align with FDP specs * Link Catalog and Biobanks * Clean up Agent table and align with BBMRI EMX1 FDP * Use semantic prefixes * Clean up Endpoint table and align with FDP specs * Add option to specify Agent type * Fix capitalization * Add ldp container structure and attributes * Change columns to align with molgenis.csv * Catalog, not NationalNodes * Don't add fdp-o metadata identifier manually * Don't 'manually' add endpoint url * date, not datetime * No fdp metadata identifier for Endpoint either * Integrate Agent/Catalog/Endpoint into molgenis.csv * Add Biobank semantics * Add semantics for Persons * Add Collections semantics * Restructure LDP containers * dct -> dcterms * Remove semantics following feedback Vittorio * Remove vcard tags from Agent * Agent -> Publishers * Add Organisations table for vcard contact points * Point contactPoint to Organisations, not Publishers * Pluralise FDP tables * Order molgenis.csv by table name * Add tag and property to Persons * Add semantics to Catalogs * CSV linting * Add properties to Catalogs table * Remove default policy * Add DataServices * Add table definition * Add Address table for Organisations.address to conform to vcard standard * Add dcterms:spatial to Collections.country * Add issued and modified to Collections * fix comma * More commas * Catalog should be Catalogs * Capitalisation * attribute name formatting * Same * Add fdp-metadata_identifier attributes to allow for output of fdp-o:metadataIdentifier in semantic mode * Neater full name computed expression which can handle null values * Add refback to Endpoints.metadata_catalog as Catalogs.endpoint * Get endpointURL into semantic mode * Use only fdp-o:hasSoftwareVersion for Endpoints.version * Add four attributes to Collections * Change Collections.publisher to ref * Add dcterms:hasVersiopn to Endpoints.version for FDP SHACL compliance * Improve dummy URL * Re-order columns * Fix label * Re-order columns * Add missing column * Add demo data for newly added tables and columns * Bump * Add required field * Add RDF config to demo data default settings * fix LDP membership relation of Catlaogs * Fix test * Correct description of dct:issued and dct:modified * Change themes, access rights and languages from hyperlinks to ontologies * Ontology formatting got messed up * Update staging area demo data to match directory schema demo data * Initial catalog membership * Initial catalog name retrieval * Rename catalog_name, add checks on Catalogs table * Add publisher to collections * Fill language, license, keywords * Make Themes conformant to EHDS * Import from src rather than installed module * Fix mocker patch paths * Add test for _set_catalog_membership * Add test for _set_fdp_collection_fields * Formatting * Check Publishers table before setting Collections.publisher * Make backwards compatible with data model without FDP fields * changed environment variable names in order to avoid clash with env variable 'username' on UNIX systems * fixed tests * Allow Python versions > 3.10 in Pipfile, update Pipfile.lock --------- Co-authored-by: Ype Zijlstra <info@ypezijlstra.frl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the main changes you did
How to test