chore: added mg_tableclass to generateTypes#6046
Merged
davidruvolo51 merged 3 commits intomasterfrom Mar 12, 2026
Merged
Conversation
mswertz
approved these changes
Mar 12, 2026
connoratrug
requested changes
Mar 12, 2026
Contributor
connoratrug
left a comment
There was a problem hiding this comment.
clean update generated types ( lint , test )
Contributor
Author
|
For now, I will ignore a few apps for now (e.g., nestor-public, directory, etc.) as they require further typescript fixes and should be addressed in another PR. In this PR, I've updated the cranio and catalogue apps. I have a separate PR to address the typescript issues in the CMS schema (#6037), so that will be completed once this PR is merged. For the apps that were updated by this PR, I ran the following-
|
|
connoratrug
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What are the main changes you did
This PR closes molgenis/GCC#2533
apps/*based on file search for// Generated (on:. Apps that required extensive typescript revisions were ignored (e.g., nestor-public, directory, etc.).How to test
export interface <tablename> extends IMgTableClass { ... }Checklist