Skip to content

chore: added mg_tableclass to generateTypes#6046

Merged
davidruvolo51 merged 3 commits intomasterfrom
chore/add-mg-tableclass-interface
Mar 12, 2026
Merged

chore: added mg_tableclass to generateTypes#6046
davidruvolo51 merged 3 commits intomasterfrom
chore/add-mg-tableclass-interface

Conversation

@davidruvolo51
Copy link
Contributor

@davidruvolo51 davidruvolo51 commented Mar 12, 2026

What are the main changes you did

This PR closes molgenis/GCC#2533

  • added mg_tableclass to generateTypes
  • updated generated types in apps/* based on file search for // Generated (on:. Apps that required extensive typescript revisions were ignored (e.g., nestor-public, directory, etc.).
    • catalogue/interfaces/catalogue
    • cranio-provider/src/types/

How to test

  • Run emx2 locally
  • Run the generateTypes command
  • View output. All tables have export interface <tablename> extends IMgTableClass { ... }

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@davidruvolo51 davidruvolo51 self-assigned this Mar 12, 2026
@davidruvolo51 davidruvolo51 marked this pull request as ready for review March 12, 2026 12:00
Copy link
Contributor

@connoratrug connoratrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean update generated types ( lint , test )

@davidruvolo51
Copy link
Contributor Author

davidruvolo51 commented Mar 12, 2026

For now, I will ignore a few apps for now (e.g., nestor-public, directory, etc.) as they require further typescript fixes and should be addressed in another PR. In this PR, I've updated the cranio and catalogue apps. I have a separate PR to address the typescript issues in the CMS schema (#6037), so that will be completed once this PR is merged.

For the apps that were updated by this PR, I ran the following-

  • formatter
  • typechecks (fixed errors where necessary)
  • tests (e2e and vitests)

@sonarqubecloud
Copy link

@connoratrug connoratrug self-requested a review March 12, 2026 13:27
@davidruvolo51 davidruvolo51 merged commit 51e0cc6 into master Mar 12, 2026
8 checks passed
@davidruvolo51 davidruvolo51 deleted the chore/add-mg-tableclass-interface branch March 12, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants