Skip to content

fix: Use explicit nullable types in parameters #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Naoray merged 1 commit into from
Feb 9, 2026
Merged

fix: Use explicit nullable types in parameters #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Billable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,10 +420,10 @@ public function invoices()
* @param $orderId
* @param null|array $data
* @param string $view
* @param \Dompdf\Options $options
* @param \Dompdf\Options|null $options
* @return \Symfony\Component\HttpFoundation\Response
*/
public function downloadInvoice($orderId, $data = [], $view = Invoice::DEFAULT_VIEW, Options $options = null)
public function downloadInvoice($orderId, $data = [], $view = Invoice::DEFAULT_VIEW, ?Options $options = null)
{
/** @var Order $order */
$order = $this->orders()->where('id', $orderId)->firstOrFail();
Expand Down
4 changes: 2 additions & 2 deletions src/Subscription.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,10 +468,10 @@ public function scheduled_order_item()
* @param Carbon|null $process_at
* @param array $item_overrides
* @param bool $fill_link Indicates whether scheduled_order_item_id field should be filled to point to the newly scheduled order item
* @param \Laravel\Cashier\Plan\Contracts\Plan $plan
* @param \Laravel\Cashier\Plan\Contracts\Plan|null $plan
* @return \Illuminate\Database\Eloquent\Model|\Laravel\Cashier\Order\OrderItem
*/
public function scheduleNewOrderItemAt(Carbon $process_at, $item_overrides = [], $fill_link = true, Plan $plan = null)
public function scheduleNewOrderItemAt(Carbon $process_at, $item_overrides = [], $fill_link = true, ?Plan $plan = null)
{
if ($this->scheduled_order_item_id) {
throw new LogicException('Cannot schedule a new subscription order item if there is already one scheduled.');
Expand Down