fix: use explicit nullable types for PHP 8.4 compatibility - #309
Merged
Conversation
Replace all remaining implicit nullable parameter types with explicit nullable type declarations to resolve PHP 8.4 deprecation warnings. PR mollie#306 previously fixed src/Billable.php; this commit addresses the remaining 13 occurrences across exception constructors, interval generators, Invoice methods, and test helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?Typedeclarations to resolve PHP 8.4 deprecation warningssrc/Billable.php; this covers the remaining instancesTest plan
vendor/bin/phpunit— all 236 tests pass with 1805 assertions?prefix to typed parameters with= nulldefault)