Fix idempotent first payment webhooks - #319
Closed
sandervanhooft wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Will open a new PR once I have my GitHub commit signing fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents replayed paid first-payment webhooks from re-running first-payment actions, creating duplicate orders, or adding balance again for the same Mollie payment.
The handler now returns the existing linked order for already-processed first payments, and the webhook controller skips duplicate aftercare updates/events in that case.
Adds regression coverage for duplicate subscription first-payment webhooks and update-payment-method balance replays.
Tests:
./vendor/bin/phpunit tests/SubscriptionBuilder/FirstPaymentSubscriptionBuilderTest.php tests/UpdatePaymentMethod/UpdatePaymentMethodTest.php tests/UpdatePaymentMethod/UpdatePaymentMethodWithoutAddingToBalanceTest.php tests/FirstPayment/FirstPaymentHandlerTest.phpand./vendor/bin/phpunit tests --display-phpunit-notices.