Bump maximum pinned conversations from 4 to 9

[Gapva]

No description provided.

[valldrac]

Have you tested what happens with the extra pinned chats if you have linked devices with Signal or use Signal Desktop?

[Gapva]

Have you tested what happens with the extra pinned chats if you have linked devices with Signal or use Signal Desktop?

good question. unfortunately, i cannot build the fork myself to test the functionality in my PR 😅, i opened this PR from my phone as i currently do not have access to my desktop. i'd love to know how stable this change is, considering that i changed a single character in a single file. if you or anyone else is able to test this, that would be greatly appreciated.

[chairmantheboring]

@Gapva @valldrac I built this to see what would happen. I didn't test it thoroughly at all. Pinning 9 conversations works (I made 9 empty groups to test it). Linking desktop works, and unpinning works there, but you can't pin new conversations there (as expected), pinning a conversation on molly syncs over fine too, even if you're over the limit of 4. There was a problem when linking an iPad, all the conversations got unpinned on Molly and Desktop, and the iPad showed 4 conversations that were pinned only on the iPad (it seemed to prefer the conversations that were pinned first). After that, I didn't do anything else and wrote this comment. I've attached debug logs from each device in question, in case anyone cares to take a look at it.

Molly: https://debuglogs.org/android/7.42.1/1ca302170f0be96f8487dbb0cc52bedf893dd6d78f17196bd6bcb6bf5744221e
Desktop: https://debuglogs.org/desktop/7.56.0-beta.2/b8771cb98ab3b59a783f1de76ec956523b1778c8bcbfbb7828dd8a229d8d8d8f.gz
iOS: https://debuglogs.org/ios/7.60.0/32ca2498e5ca38ad2195ab70db55874017e987e3c7e06221d3e97c2550c6e471.zip

[valldrac]

Thanks for testing it. I get that for this PR to work well with linked devices, we'd need to filter which pinned chats get synced. Basically, limit it to just 4. That means syncing only the top 4 and keeping the rest local. We should sort the pinned chats by some property, and sync the first 4 to keep the list consistent across devices.

We should also test what happens if someone imports a Molly backup into Signal with more than 4 pinned chats. And apply the same logic if there's any issue.

Also, handling incoming pinned chat lists from linked devices is tricky too. Another reason we usually avoid changing these limits in Molly. It's never just a simple line change.

[The-Nickname]

There also is a related feature request upstream in the Signal Forum: https://community.signalusers.org/t/allow-for-more-than-4-pinned-chats/19869