Cleanup - Initial Project Refactor #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also worked on having go.mod reflect true repository name.
Making sure we're only using the flag that we're passing in.
|
@amenocal @kuhlman-labs please do an integration test and review the above. I have a bit more changes incoming regarding unit tests, but getting this initial PR out there. :) |
ssulei7
commented
Jul 30, 2024
| } | ||
| } | ||
|
|
||
| func replaceSHA(data interface{}, oldSHA string, newSHA string) { |
There was a problem hiding this comment.
In a later PR, I would like to rework this function as I'm getting super spooked around the usage of empty interfaces here (e.g., any type)
amenocal
approved these changes
Jul 30, 2024
|
@ssulei7 LGTM. My integration tests passed, I just added one commit to add in the issue_events file to be processed as well. |
kuhlman-labs
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.modto reflect source repository namecmd/root.gointointernal/commitremap. Chances are some functions around file processing can be broken out of here as well, but we'll see.func main, and did an inline function for the root cmd. I didn't see much of a point of adding a concrete function for the root command at this point in time 🤷🏽