Skip to content

Replaces find with ls #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrianAtZetica wants to merge 2 commits into
base: main
Choose a base branch
from
+37 −37
Open

Replaces find with ls #203

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeea532
Replaces find with ls so it doesnt recursively search a users entire …
BrianAtZetica May 16, 2026
9014dee
Potential fix for pull request finding
BrianAtZetica May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 37 additions & 37 deletions gh-repo-stats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,10 +385,16 @@
######################################################
# Need to see if there is a file that already exists #
######################################################
EXISTING_JSON_CMD=$(find . -name "$ORG_NAME-all_repos-*.json" |grep . 2>&1)
ERROR_CODE=$?
if [ "${ERROR_CODE}" -eq 0 ]; then
JSON_FILE_NAME="${EXISTING_JSON_CMD:2}"
EXISTING_JSON_CMD=$(ls "$ORG_NAME-all_repos-*.json" 2>/dev/null | head -1)

Check notice

Code scanning / shellcheck

SC2012 Note

Use find instead of ls to better handle non-alphanumeric filenames.
Comment thread
BrianAtZetica marked this conversation as resolved.
Outdated

################################
# Check ls result is not empty #
################################
if [[ -n "${EXISTING_JSON_CMD}" ]]; then
JSON_FILE_NAME="${EXISTING_JSON_CMD}"
Debug "Found existing JSON file, using: $JSON_FILE_NAME"
else
Debug "No existing JSON file found, creating: $JSON_FILE_NAME"
fi
fi

Expand All @@ -402,21 +408,19 @@
######################################################
# Need to see if there is a file that already exists #
######################################################
EXISTING_FILE_CMD=$(find . -name "$ORG_NAME-all_repos-*" |grep . 2>&1)

#######################
# Load the error code #
#######################
ERROR_CODE=$?
EXISTING_FILE_CMD=$(ls "$ORG_NAME-all_repos-"* 2>/dev/null | head -1)

Check notice

Code scanning / shellcheck

SC2012 Note

Use find instead of ls to better handle non-alphanumeric filenames.

@BrianAtZetica BrianAtZetica May 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to resolve this concern. Switchign to ls and looking non-recursively solved my problem of an unexpected OneDrive dowload trigger. If it isnt appropriate for all users, you'll have to reject the PR. Thanks


##############################
# Check the shell for errors #
##############################
if [ "${ERROR_CODE}" -eq 0 ]; then
################################
# Check ls result is not empty #
################################
if [[ -n "${EXISTING_FILE_CMD}" ]]; then
# There is already file
# Going to use and append
OUTPUT_FILE_NAME="${EXISTING_FILE_CMD:2}"
OUTPUT_FILE_NAME="${EXISTING_FILE_CMD}"
EXISTING_FILE=1
Debug "Found existing CSV file, using: $OUTPUT_FILE_NAME"
else
Debug "No existing CSV file found, creating: $OUTPUT_FILE_NAME"
fi
fi

Expand All @@ -426,20 +430,18 @@
######################################################
# Need to see if there is a file that already exists #
######################################################
EXISTING_FILE_CMD=$(find . -name "$ORG_NAME-repo-conflicts-*" |grep . 2>&1)

#######################
# Load the error code #
#######################
ERROR_CODE=$?
EXISTING_FILE_CMD=$(ls "$ORG_NAME-repo-conflicts-"* 2>/dev/null | head -1)

Check notice

Code scanning / shellcheck

SC2012 Note

Use find instead of ls to better handle non-alphanumeric filenames.

##############################
# Check the shell for errors #
##############################
if [ "${ERROR_CODE}" -eq 0 ]; then
################################
# Check ls result is not empty #
################################
if [[ -n "${EXISTING_FILE_CMD}" ]]; then
# There is already file
# Going to use and append
REPO_CONFLICTS_OUTPUT_FILE="${EXISTING_FILE_CMD:2}"
REPO_CONFLICTS_OUTPUT_FILE="${EXISTING_FILE_CMD}"
Debug "Found existing Repo Conflicts CSV file, using: $REPO_CONFLICTS_OUTPUT_FILE"
else
Debug "No existing Repo Conflicts CSV file found, creating: $REPO_CONFLICTS_OUTPUT_FILE"
fi

if ! echo "conflict qty, repo name, org names" > "${REPO_CONFLICTS_OUTPUT_FILE}"
Expand All @@ -455,20 +457,18 @@
######################################################
# Need to see if there is a file that already exists #
######################################################
EXISTING_FILE_CMD=$(find . -name "$ORG_NAME-team-conflicts-*" |grep . 2>&1)
EXISTING_FILE_CMD=$(ls "$ORG_NAME-team-conflicts-"* 2>/dev/null | head -1)

Check notice

Code scanning / shellcheck

SC2012 Note

Use find instead of ls to better handle non-alphanumeric filenames.

#######################
# Load the error code #
#######################
ERROR_CODE=$?

##############################
# Check the shell for errors #
##############################
if [ "${ERROR_CODE}" -eq 0 ]; then
################################
# Check ls result is not empty #
################################
Comment on lines +462 to +464
if [[ -n "${EXISTING_FILE_CMD}" ]]; then
# There is already file
# Going to use and append
TEAM_CONFLICTS_OUTPUT_FILE="${EXISTING_FILE_CMD:2}"
TEAM_CONFLICTS_OUTPUT_FILE="${EXISTING_FILE_CMD}"
Debug "Found existing Team Conflicts CSV file, using: $TEAM_CONFLICTS_OUTPUT_FILE"
else
Debug "No existing Team Conflicts CSV file found, creating: $TEAM_CONFLICTS_OUTPUT_FILE"
fi

if ! echo "conflict qty, team name, org names" > "${TEAM_CONFLICTS_OUTPUT_FILE}"
Expand Down
Loading