Merged
Conversation
Introduce a new expert setting to ignore all ToFu-only members in encrypted groups once at least one member isn't ToFu-only anymore. Introduce a new expert setting to drop calls not being omemo-verified.
This reverts commit 2b8e6e3. This commit was applied because many users complained that encryption was "broken" after verifying a fingerprint and then migrating to or adding a new device. This was a UX decision and we tried to mitigate the security impact by informing the users about new devices, both in their own account (as push notification) as well as for the contacts they were chatting with (as yellow status message in the chat itself). Users that cared about security could then manually disable trust for these new devices. In the hope that users are now more familiar with trust management, we now revert this commit and introduce a new setting to switch between the "better UX" one and this one in a new commit.
--> force a key transport message with 1% probability (~ every 100th message)
If that device is still active, it will readd itself to the devicelist again.
This should fix this crash: CRASH(NSInternalInconsistencyException): attempt to insert row 0 into section 1, but there are only 0 rows in section 1 after the update
Sometimes ejabberd sends a mam fin element with complete=false, but missing rsm last element. Interprete those results as complete=true, too.
IOS_ONLY - Fixed broken video calls by fixing bug in Mozilla's webrtc-sdp library - Reworked complete OMEMO trust management - Fixed spurious "new OMEMO device found" notifications and status messages - Introduced some new OMEMO expert settings - Improved UI responsiveness in some rare cases - Made sure to periodically advance the OMEMO DH-ratchet even on devices only used for receiving messages, not sending - Made sure to remove old OMEMO devices not seen for more than 90 days from own devicelist
This fixes the real cause for the black video bug.
- Better fix for audio/video codec issues (aka black video stream)
- Fixed crash when receiving broken OMEMO bundles
The last fix was incomplete, thanks Isadora.
- Fixed crash on broken OMEMO bundles again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IOS_ONLY - Fixed broken video calls by fixing bug in Mozilla's webrtc-sdp library