Asset-based ISO 27005:2022 alignment#34
Open
ruslanbaidan wants to merge 23 commits into
Open
Conversation
…arch erased characters.
Asset-based ISO 27005:2022 alignment
…e windows navigation.
…ory params display.
There was a problem hiding this comment.
Pull request overview
This PR adds UI and service-layer support for several ISO 27005:2022-aligned, asset-centric risk governance features (risk sources, reassessment triggers, supervisors, residual acceptance governance/history), plus related UI refreshes across ANR screens.
Changes:
- Introduces new dialogs/pages for supervisors, reassessment trigger criteria, and risks management, and wires them into ANR menus/exports.
- Refactors risk sheets (information + operational) to add governance/review, residual acceptance, and history sections (with resizable history columns).
- Updates multiple
$resourceservices to computeurlAnrIddynamically and adds new API services for risk sources, reassessment triggers, and interested parties.
Reviewed changes
Copilot reviewed 39 out of 41 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| views/supervisors.html | New dialog to manage analysis supervisors (incl. roles/linked users). |
| views/reassessment-triggers.html | New dialog to manage reassessment trigger criteria for an analysis. |
| views/export.objlibs.html | Adds new export toggles for interested parties and reassessment triggers. |
| views/edit.evalcontext.html | Adds “Interested parties & requirements” tab to evaluation context UI. |
| views/create.instance.html | Updates impact evaluation dialog title wording. |
| views/anr.risksmanagement.html | New risks management view for batch review/residual acceptance updates. |
| views/anr.layout.html | Adds tools menu entries for reassessment triggers, risks management, supervisors; updates menu button styling classes. |
| views/anr.instance.html | Updates asset actions menu button styling; updates risk tabs styling/locking. |
| views/anr.home.html | Adds reassessment triggers + supervisors actions; updates risk tabs styling/locking. |
| views/_table_risks.html | Adds risk source ordering/column and residual acceptance status indicators; wraps table in panel container. |
| views/_table_risks_op.html | Adds risk source column and residual acceptance status indicators; wraps table in panel container. |
| views/_risk_sheet.html | Major redesign: collapsible sections for identification/governance/treatment/residual acceptance/history; adds risk source selector and history table. |
| views/_oprisk_sheet.html | Major redesign mirroring info risk sheet: collapsible sections including residual acceptance + history. |
| views/_anr.kbmgmt.html | Reorganizes KB management into grouped tabs; adds Risk Sources tab in support group. |
| views/_anr.evalscales.html | Updates wording for impact evaluation headers. |
| src/VulnService.js | Makes urlAnrId dynamic via function for FO mode. |
| src/ThreatService.js | Makes urlAnrId dynamic via function for FO mode. |
| src/TagService.js | Makes urlAnrId dynamic via function for FO mode. |
| src/SoaScaleCommentService.js | Makes urlAnrId dynamic via function for FO mode. |
| src/SOACategoryService.js | Makes urlAnrId dynamic via function for FO mode. |
| src/RiskSourceService.js | New $resource service for CRUD on risk sources. |
| src/RiskService.js | Makes urlAnrId dynamic via function for FO mode. |
| src/ReferentialService.js | Makes urlAnrId dynamic via function for FO mode. |
| src/RecordService.js | Makes urlAnrId dynamic via function for FO mode across record resources. |
| src/ReassessmentTriggerService.js | New $resource service for reassessment triggers. |
| src/QuestionService.js | Makes urlAnrId dynamic via function for FO mode. |
| src/ObjlibService.js | Makes urlAnrId dynamic via function for FO mode across object resources. |
| src/MetadataInstanceService.js | Makes urlAnrId dynamic via function for FO mode. |
| src/MeasureService.js | Makes urlAnrId dynamic via function for FO mode. |
| src/MeasureMeasureService.js | Makes urlAnrId dynamic via function for FO mode. |
| src/InterestedPartyService.js | New $resource service for interested parties. |
| src/HistoryResizableTableDirective.js | New directive enabling resizable columns in history tables. |
| src/CategoryService.js | Makes urlAnrId dynamic via function for FO mode. |
| src/AssetService.js | Makes urlAnrId dynamic via function for FO mode (incl. import resource). |
| src/AnrService.js | Adds supervisors, risks management, residual acceptance decision endpoints, history endpoint, and instance-risk patch wrapper. |
| src/AnrObjectInstanceCtrl.js | Adds auto tab selection logic based on available risk types/counts. |
| src/AnrKbMgmtCtrl.js | Adds KB group tab logic and implements Risk Sources KB tab + dialogs. |
| src/AmvService.js | Makes urlAnrId dynamic via function for FO mode. |
| package-lock.json | Adds npm lockfile (minimal, matches package.json metadata). |
| css/anr.css | Adds styling for new dialogs/tables/sheets, KB group tabs, and new menu button styling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <md-button ng-if="form.id" ng-click="resetForm()" ng-disabled="saving"> | ||
| {{ 'Cancel edition' | translate }} | ||
| </md-button> | ||
| <md-button class="md-primary" ng-click="saveSupervisor()" ng-disabled="isAnrReadOnly || saving || !form.name.trim()"> |
Comment on lines
+21
to
+23
| 'patch': { | ||
| method: 'PUT' | ||
| }, |
Comment on lines
+21
to
+23
| 'patch': { | ||
| method: 'PUT' | ||
| }, |
| class="md-padding-double risk-sheet-layout" | ||
| layout="column" | ||
| ng-class="{'risk-sheet-readonly': isAnrReadOnly, 'risk-sheet-editable': !isAnrReadOnly}" | ||
| ng-init="riskSheetSections = riskSheetSections || { identification: true, governance: true, treatment: true, residualAcceptance: true }"> |
Comment on lines
+1067
to
+1070
| $mdDialog.show(prompt.multiple(true)).then(function(label) { | ||
| var payload = { | ||
| label: label.trim() | ||
| }; |
… of each one, to simplify the access.
* origin/stage: Added the supervisors creation buttons on the risks edit pages. Fixed the supervisors view path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.