fix: rewrite SI table filtering guidance and add rewrite requirement - #19
Merged
Conversation
The existing SI paragraph (added in PR #11) had several style issues: vague framing, a confusing "PMT-centric" label, and no guidance on rewriting SDT/EIT when derived from an MPTS source. * Replace the paragraph with a clear explanation: the PMT references only program elementary-stream PIDs and never references the fixed service information tables (NIT, SDT/BAT, EIT, TDT/TOT); the filter therefore drops them silently. * Expand all acronyms on first use. * Split the two SHOULD obligations (retain, declare) into separate sentences. * Add rewrite guidance: because SDT and EIT from an MPTS describe all programs, publishers SHOULD filter or rewrite them to include only entries for the carried program. NIT and TDT/TOT are broadcast-wide and do not require per-program rewriting. Addresses issue #13. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mondain
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SI table paragraph added in PR #11 had two gaps:
Style: The paragraph used "PMT-centric" as a label for the filter rule, referenced "the retain list above," used "well-known" informally, and bundled two SHOULD obligations into one sentence.
Substance: No guidance existed on rewriting SI tables when filtering from an MPTS. A retained SDT or EIT carried verbatim from an MPTS still advertises all programs in the multiplex, which is non-conformant for a derived single-program track.
This is raised in issue #13.
Changes
m2tsSiPids) into separate sentences.Closes #13.