Skip to content

include CJS build output in mcp-adapter publish #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encodedz merged 1 commit into from
Mar 9, 2026
Merged

include CJS build output in mcp-adapter publish #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/mcp-adapter/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"executor": "nx:run-commands",
"outputs": ["{projectRoot}/dist"],
"options": {
"command": "tsc --build packages/mcp-adapter/tsconfig.json"
"command": "cd packages/mcp-adapter && npm run build"
Copy link
Copy Markdown
Collaborator

@encodedz encodedz Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the CD ? shouldn't need to

Copy link
Copy Markdown
Contributor Author

@EranZidkiya EranZidkiya Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use nx:run-commands from the root, so npm run build will execute the root build script. In all other packages this is the same, maybe was missed here

Copy link
Copy Markdown
Collaborator

@encodedz encodedz Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, It should have a sourceRoot option which should opt-in this behaviour - but if all the wokrspace is using this convention lets proceed.

}
},
"test": {
Expand Down
Loading