Skip to content

fix: remove postinstall wrapper dependency#168

Open
omribz156 wants to merge 1 commit into
mondaycom:masterfrom
omribz156:codex/remove-global-postinstall-wrapper
Open

fix: remove postinstall wrapper dependency#168
omribz156 wants to merge 1 commit into
mondaycom:masterfrom
omribz156:codex/remove-global-postinstall-wrapper

Conversation

@omribz156

Copy link
Copy Markdown

Summary

  • remove the postinstall-postinstall runtime dependency from the published CLI package
  • keep the existing package postinstall script as patch-package, so npm still applies the package patches during install without the extra wrapper re-running the script through Yarn/npm

This is aimed at #146. I could not reproduce the published global install failure in a clean Windows temp prefix, but the stack in the issue points at node_modules/postinstall-postinstall/run.js; removing that wrapper keeps the install path simpler while preserving the package's own patch step.

Verification

  • yarn build
  • npm pack --ignore-scripts --pack-destination ..\artifacts\pack
  • npm install --prefix ..\artifacts\npm-prefix-fixed -g ..\artifacts\pack\mondaycom-apps-cli-4.10.8.tgz
  • installed package check confirmed postinstall-postinstall is not installed
  • ..\artifacts\npm-prefix-fixed\mapps.cmd --version
  • git diff --check

I also tried yarn test --runInBand, but one create test failed in my local Windows run while doing a live template clone and comparing spinner output (> vs ), so I did not count that as verification for this packaging-only change.

This was implemented with Codex assistance, with the final diff manually reviewed and kept focused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant