fix: remove postinstall wrapper dependency#168
Open
omribz156 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postinstall-postinstallruntime dependency from the published CLI packagepostinstallscript aspatch-package, so npm still applies the package patches during install without the extra wrapper re-running the script through Yarn/npmThis is aimed at #146. I could not reproduce the published global install failure in a clean Windows temp prefix, but the stack in the issue points at
node_modules/postinstall-postinstall/run.js; removing that wrapper keeps the install path simpler while preserving the package's own patch step.Verification
yarn buildnpm pack --ignore-scripts --pack-destination ..\artifacts\packnpm install --prefix ..\artifacts\npm-prefix-fixed -g ..\artifacts\pack\mondaycom-apps-cli-4.10.8.tgzpostinstall-postinstallis not installed..\artifacts\npm-prefix-fixed\mapps.cmd --versiongit diff --checkI also tried
yarn test --runInBand, but onecreatetest failed in my local Windows run while doing a live template clone and comparing spinner output (>vs✔), so I did not count that as verification for this packaging-only change.This was implemented with Codex assistance, with the final diff manually reviewed and kept focused.