Support language script subtags#384
Merged
Merged
Conversation
mondeja
added
the
new feature
mondeja
force-pushed
the
feat-script-subtags
branch
from
ae360ce to
748a2fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #368
This implementation needs to be posponed for v0.3 because it contains a breaking change: the
idfield of theLanguagestruct is converted to&'static strfromunic_langid::LanguageIdentifier. This is required because language identifiers with tags useBoxes at runtime, so the unique way to maintain thelanguagesarray const is building langids only at run-time when needed. Also, this change makes theLanguagetype smaller.