Skip to content

🐛 fix azure provider to use the right settings types #5415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

syrull
Copy link
Contributor

@syrull syrull commented Apr 4, 2025

There is a wrong type that is being used for the settings regarding MCAS, Sentinel and WDATP

@syrull
Copy link
Contributor Author

syrull commented Apr 4, 2025

cnspec> azure.subscription.cloudDefender.settingsMCAS { * }
azure.subscription.cloudDefender.settingsMCAS: {
  properties: {
    enabled: true
  }
  name: "MCAS"
  type: "Microsoft.Security/settings"
  kind: "DataExportSettings"
  id: "/subscriptions/e9ee8090-9784-42d6-9534-bc1d881eeff6/providers/Microsoft.Security/settings/MCAS"
}
cnspec> azure.subscription.cloudDefender.settingsSentinel { * }
azure.subscription.cloudDefender.settingsSentinel: {
  name: "Sentinel"
  id: "/subscriptions/e9ee8090-9784-42d6-9534-bc1d881eeff6/providers/Microsoft.Security/settings/Sentinel"
  properties: {
    enabled: false
  }
  kind: "AlertSyncSettings"
  type: "Microsoft.Security/settings"
}
cnspec> azure.subscription.cloudDefender.settingsWDATP { * }
azure.subscription.cloudDefender.settingsWDATP: {
  properties: {
    enabled: false
  }
  type: "Microsoft.Security/settings"
  id: "/subscriptions/e9ee8090-9784-42d6-9534-bc1d881eeff6/providers/Microsoft.Security/settings/WDATP"
  name: "WDATP"
  kind: "DataExportSettings"
}
cnspec> 

This comment has been minimized.

@mm-weber mm-weber requested a review from afiune April 6, 2025 16:12
@mm-weber
Copy link
Contributor

mm-weber commented Apr 6, 2025

Tried and tested, great work @syrull !
Screenshot 2025-04-06 at 18 12 11

From my point of view we can ship it.
Can you have a look please @afiune ?

Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afiune afiune changed the title Fix for the azure provider to use the right settings types 🐛 fix azure provider to use the right settings types Apr 9, 2025
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Test Results

3 693 tests  ±0   3 689 ✅ ±0   1m 58s ⏱️ -13s
  399 suites ±0       4 💤 ±0 
   30 files   ±0       0 ❌ ±0 

Results for commit a905fef. ± Comparison against base commit e9f797a.

@afiune afiune merged commit 62a5f7f into main Apr 9, 2025
17 checks passed
@afiune afiune deleted the dimitar/add-properties-field-to-clouddefenderservicesettings branch April 9, 2025 22:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants