Skip to content

fix: use published image matching git tag in Helm chart installation#1413

Merged
slntopp merged 1 commit intomainfrom
mik/fix-int-test-errors-on-publish
Mar 9, 2026
Merged

fix: use published image matching git tag in Helm chart installation#1413
slntopp merged 1 commit intomainfrom
mik/fix-int-test-errors-on-publish

Conversation

@slntopp
Copy link
Copy Markdown
Member

@slntopp slntopp commented Mar 9, 2026

No description provided.

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple CI fix looks correct but GIT_REF_NAME should be quoted in the shell expansion to avoid word-splitting issues.

Comment thread .github/workflows/helm-tests.yaml
@slntopp slntopp force-pushed the mik/fix-int-test-errors-on-publish branch from 78fb6fd to 6124b7e Compare March 9, 2026 15:16
mondoo-code-review[bot]

This comment was marked as resolved.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2026

Test Results

0 files   -  2  0 suites   - 2   0s ⏱️ ±0s
0 tests  -  6  0 ✅ ±0  0 💤 ±0  0 ❌  -  6 
0 runs   - 10  0 ✅ +2  0 💤 ±0  0 ❌  - 12 

Results for commit d2edb89. ± Comparison against base commit d1ce8c1.

♻️ This comment has been updated with latest results.

VasilSirakov
VasilSirakov previously approved these changes Mar 9, 2026
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable fix to use git tag for image matching, but GIT_REF_NAME is only set in the first step's env, not the second.

Comment thread .github/workflows/helm-tests.yaml
@slntopp
Copy link
Copy Markdown
Member Author

slntopp commented Mar 9, 2026

/review

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable fix to use git tag for published image, but GIT_REF_NAME env var is missing in the second usage block.

Comment thread .github/workflows/helm-tests.yaml
@slntopp
Copy link
Copy Markdown
Member Author

slntopp commented Mar 9, 2026

/review
it is not missing, it's literally there at line 126, stop hallucinating

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward fix to use git tag for published image; minor issue with GIT_REF_NAME not being passed to the second shell step.

Comment thread .github/workflows/helm-tests.yaml
@slntopp slntopp force-pushed the mik/fix-int-test-errors-on-publish branch from d2edb89 to bb9443c Compare March 9, 2026 15:29
@mondoo-code-review mondoo-code-review bot dismissed their stale review March 9, 2026 15:29

Superseded by new review

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward fix to use the git tag for the published image in Helm chart installation, with appropriate guard checks.

@slntopp slntopp merged commit 8d2bcab into main Mar 9, 2026
16 of 17 checks passed
@slntopp slntopp deleted the mik/fix-int-test-errors-on-publish branch March 9, 2026 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants