⭐️ Improve Helm chart management and cleanup#1374
Merged
chris-rock merged 3 commits intomainfrom Feb 12, 2026
Merged
Conversation
038688a to
bf1e7ec
Compare
Contributor
806c832 to
54fca28
Compare
imilchev
previously approved these changes
Feb 12, 2026
- Add pre-delete hook to clean up MondooAuditConfig resources on uninstall - Add cleanup subcommand to operator CLI (replaces external kubectl image) - Replace helmify-based chart generation with hand-maintained templates - Add hack/update-helm-crds.sh script to update only CRDs from generated sources - Add chart-testing (ct) linting to CI and Makefile - Add Mondoo icon to Helm chart - Add Helm chart integration tests The cleanup hook now uses the operator's own image instead of a third-party kubectl image, eliminating a supply chain dependency. Fixes #849, Fixes #821 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…RD script - Add hook-failed to cleanup Job's hook-delete-policy so failed jobs don't block subsequent helm install attempts - Remove unused webhook ServiceAccount and values (webhooks removed in v12.1.0) - Add validation step to update-helm-crds.sh to catch silent sed failures Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
54fca28 to
71f1621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #849 and #821 by improving Helm chart management and adding proper cleanup on uninstall.
Changes
mondoo-operator cleanupCLI command (replaces external kubectl image dependency)hack/update-helm-crds.shto update only CRDs from generated sourcesct lintto CI pipeline and Makefilehelm/lintis now included in the defaultmake linttargetWhy
bitnami/kubectlimagehelm uninstallNew Make Targets
Test plan
make helm/lintpasseshelm templaterenders correctlygo build ./...)helm install/helm uninstallcycleFixes #849, Fixes #821