Skip to content

🐛 fix integration tests errors#1411

Merged
slntopp merged 6 commits intomainfrom
mik/fix-integration-tests
Mar 9, 2026
Merged

🐛 fix integration tests errors#1411
slntopp merged 6 commits intomainfrom
mik/fix-integration-tests

Conversation

@slntopp
Copy link
Copy Markdown
Member

@slntopp slntopp commented Mar 9, 2026

  • fix: refactor mondoooperatorconfig.yaml to use set for spec properties
  • feat: add helm integration tests workflow and integrate with publish and tests workflows

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactors Helm template to build spec as a dict then serialize, avoiding empty spec output — looks correct but loses quoting on string values.

Comment thread charts/mondoo-operator/templates/mondoooperatorconfig.yaml
Comment thread charts/mondoo-operator/templates/mondoooperatorconfig.yaml
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor extracting helm tests into reusable workflow; one potential issue with empty spec output in the Helm template.

Comment thread charts/mondoo-operator/templates/mondoooperatorconfig.yaml
Comment thread .github/workflows/helm-tests.yaml
Comment thread .github/workflows/helm-tests.yaml Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 9, 2026

Test Results

 2 files  ± 0   2 suites  ±0   26m 1s ⏱️ + 21m 48s
13 tests + 5  11 ✅ + 5  2 💤 +1  0 ❌  - 1 
26 runs  +10  22 ✅ +10  4 💤 +2  0 ❌  - 2 

Results for commit 873487b. ± Comparison against base commit b195dcb.

This pull request skips 1 test.
go.mondoo.com/mondoo-operator/tests/integration ‑ TestHelmChartSuite/TestHelmInstallAndUninstall

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactoring of helm tests into reusable workflow with a Helm template fix, but has a potential image tag issue.

Comment thread .github/workflows/helm-tests.yaml Outdated
Comment thread .github/workflows/helm-tests.yaml
Comment thread .github/workflows/helm-tests.yaml
Comment thread charts/mondoo-operator/templates/mondoooperatorconfig.yaml
@mondoo-code-review mondoo-code-review Bot dismissed their stale review March 9, 2026 11:14

Superseded by new review

mondoo-code-review[bot]
mondoo-code-review Bot previously approved these changes Mar 9, 2026
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplifies CI image tag logic by reusing Makefile's VERSION, improving maintainability with no behavioral change.

mondoo-code-review[bot]
mondoo-code-review Bot previously approved these changes Mar 9, 2026
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pins Helm to v3.17.0 and disables config creation in integration tests to fix test failures.

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracts helm integration tests into a reusable workflow and fixes Helm template rendering issues.

Comment thread .github/workflows/publish.yaml
Comment thread .github/workflows/helm-tests.yaml
Comment thread .github/workflows/tests.yaml
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm integration tests are extracted into a reusable workflow and the operator config template is refactored to avoid empty spec fields.

@slntopp slntopp merged commit 91e80d5 into main Mar 9, 2026
30 checks passed
@slntopp slntopp deleted the mik/fix-integration-tests branch March 9, 2026 12:41
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant