Skip to content

fix: skip minikube image load and pass git tag as VERSION for pre-built operator in helm tests#1412

Merged
slntopp merged 1 commit intomainfrom
mik/fix-int-test-on-publish
Mar 9, 2026
Merged

fix: skip minikube image load and pass git tag as VERSION for pre-built operator in helm tests#1412
slntopp merged 1 commit intomainfrom
mik/fix-int-test-on-publish

Conversation

@slntopp
Copy link
Copy Markdown
Member

@slntopp slntopp commented Mar 9, 2026

No description provided.

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is correct but github.ref_name should be quoted to prevent word-splitting or injection.

Comment thread .github/workflows/helm-tests.yaml Outdated
@slntopp slntopp force-pushed the mik/fix-int-test-on-publish branch from 1198223 to c687489 Compare March 9, 2026 13:35
@mondoo-code-review mondoo-code-review bot dismissed their stale review March 9, 2026 13:35

Superseded by new review

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean fix for CI workflow: avoids script injection and correctly handles pre-built operator images in helm tests.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2026

Test Results

  7 files  +  5   44 suites  +42   1h 27m 43s ⏱️ + 1h 27m 43s
393 tests +387  393 ✅ +393  0 💤 ±0  0 ❌  -  6 
459 runs  +449  453 ✅ +455  6 💤 +6  0 ❌  - 12 

Results for commit c687489. ± Comparison against base commit 91e80d5.

♻️ This comment has been updated with latest results.

@slntopp slntopp merged commit d1ce8c1 into main Mar 9, 2026
30 checks passed
@slntopp slntopp deleted the mik/fix-int-test-on-publish branch March 9, 2026 14:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant