🧪 Test suites for Vault and Mondoo Integration#1424
Merged
slntopp merged 3 commits intorefactor/vault-auth-operator-sidefrom Mar 13, 2026
Merged
🧪 Test suites for Vault and Mondoo Integration#1424slntopp merged 3 commits intorefactor/vault-auth-operator-sidefrom
slntopp merged 3 commits intorefactor/vault-auth-operator-sidefrom
Conversation
Member
slntopp
commented
Mar 13, 2026
slntopp
commented
- regenerate CRDs
![mondoo-code-review[bot]](https://avatars.githubusercontent.com/in/2834902?s=60&v=4){kind=small}
chris-rock
approved these changes
Mar 13, 2026
slntopp
force-pushed
the
refactor/vault-auth-operator-side
branch
from
b4bb4b9 to
e84720d
Compare
slntopp
force-pushed
the
mik/v13/test-vault-and-integration
branch
from
69a00cd to
c4182e8
Compare
slntopp
force-pushed
the
mik/v13/test-vault-and-integration
branch
from
c4182e8 to
997b05a
Compare
| - name: vault | ||
| user: | ||
| token: %s | ||
| token: "%s" |
There was a problem hiding this comment.
🟡 warning — Quoting the token with "%s" will embed literal double quotes into the YAML value. If the Vault-issued token ever contains a double quote or backslash, the kubeconfig will be malformed YAML. Consider using yaml.Marshal or at minimum escaping special characters within the token string. That said, Vault SA tokens are typically base64-encoded JWTs so this is unlikely to bite in practice.
slntopp
merged commit 9dc2874
into
refactor/vault-auth-operator-side
16 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.