Skip to content

✨ Extend operator-side labeling/annotation for asset routing #1480

Merged
slntopp merged 1 commit intomainfrom
mik/assets-routing
Apr 21, 2026
Merged

✨ Extend operator-side labeling/annotation for asset routing #1480
slntopp merged 1 commit intomainfrom
mik/assets-routing

Conversation

@slntopp
Copy link
Copy Markdown
Member

@slntopp slntopp commented Apr 21, 2026

No description provided.

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asset routing annotations are added inconsistently across controllers—two controllers inline the map while a third uses a shared helper.

Comment thread controllers/container_image/resources.go Outdated
Comment thread controllers/nodes/resources.go Outdated
Comment thread tests/e2e/scripts/apply-mondoo-config-asset-routing.sh
Comment thread tests/e2e/scripts/verify-asset-routing.sh Outdated
@slntopp slntopp force-pushed the mik/assets-routing branch from ef80ff2 to ce8910b Compare April 21, 2026 12:05
@mondoo-code-review mondoo-code-review Bot dismissed their stale review April 21, 2026 12:06

Superseded by new review

Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User-defined annotations can silently overwrite operator routing annotations, breaking server-side asset routing.

Comment thread controllers/k8s_scan/resources.go Outdated
Comment thread controllers/container_image/resources.go Outdated
Comment thread controllers/nodes/resources.go Outdated
Comment thread pkg/utils/mondoo/gc.go
…ctions

✨ Implement asset routing test with MondooAuditConfigs and related scripts

✨ Refactor asset routing annotations to use centralized AuditConfigAnnotations function

✨ Reorder asset annotation application to prioritize user-defined annotations over operator-managed ones
@slntopp slntopp force-pushed the mik/assets-routing branch from ce8910b to 1d0c71b Compare April 21, 2026 12:18
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds operator-managed annotations to assets for server-side routing, with supporting e2e tests and GC skip for org-level SAs.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Test Results

  7 files  ±0   44 suites  ±0   1h 39m 12s ⏱️ + 1m 23s
462 tests ±0  462 ✅ ±0  0 💤 ±0  0 ❌ ±0 
528 runs  ±0  522 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit 1d0c71b. ± Comparison against base commit 75d8535.

♻️ This comment has been updated with latest results.

@slntopp slntopp merged commit b5fc8f5 into main Apr 21, 2026
30 checks passed
@slntopp slntopp deleted the mik/assets-routing branch April 21, 2026 12:50
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant