Skip to content

✨ adds llx.IPData() for easy initialization#5283

Merged
arlimus merged 2 commits intomainfrom
afiune/ip/llx/raw
Mar 4, 2025
Merged

✨ adds llx.IPData() for easy initialization#5283
arlimus merged 2 commits intomainfrom
afiune/ip/llx/raw

Conversation

@afiune
Copy link
Copy Markdown
Contributor

@afiune afiune commented Mar 3, 2025

This helps us write

llx.IPData("1.2.3.4")

rather than

&llx.RawData{Type: types.IP, Value: "1.2.3.4"}

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
@afiune afiune requested a review from arlimus March 3, 2025 16:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2025

Test Results

3 478 tests  ±0   3 474 ✅ ±0   1m 51s ⏱️ -1s
  392 suites ±0       4 💤 ±0 
   30 files   ±0       0 ❌ ±0 

Results for commit a90a972. ± Comparison against base commit e47c383.

♻️ This comment has been updated with latest results.

@arlimus
Copy link
Copy Markdown
Member

arlimus commented Mar 4, 2025

Nice catch, thank you! I had a feeling I forgot something 🙈

There is another stringify method missing in llx/rawdata.go which will turn this test green. Feel free to ping me and I'll approve it

Signed-off-by: Salim Afiune Maya <afiune@mondoo.com>
@afiune
Copy link
Copy Markdown
Contributor Author

afiune commented Mar 4, 2025

@arlimus ping

Copy link
Copy Markdown
Member

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pong 😁

@arlimus arlimus merged commit 293a023 into main Mar 4, 2025
@arlimus arlimus deleted the afiune/ip/llx/raw branch March 4, 2025 18:51
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants