✨ ip.cidr, ip.address and raw IP storage

[arlimus]

Adds the address field, which only returns the address itself:

# obscure IPv4, printed nicely
> ip("192.168.0.0/24").address
"192.168.0.0"

> ip("2001:db8:3c4d:15::1a2f:1a2b/48").address
"2001:db8:3c4d:15::1a2f:1a2b"

Adds the cidr field, which returns the CIDR notation of the IP address. We fill in the prefix length for IPv4 class A/B/C networks and IPv6 automatically:

# obscure IPv4, printed nicely
> ip(2885681153).cidr
"172.0.0.1/16"

> ip("2001:db8:3c4d:15::1a2f:1a2b").cidr
"2001:db8:3c4d:15::1a2f:1a2b/64"

internal:

The bigger thing this PR does is overhaul the internal data structure for IP so we don't have to constantly parse it again. This increases efficiency but also means we have to take care of serialization/deserialization.

• Mask was renamed to PrefixLength because that's what it actually is
• NewIP is really a ParseIP which also separates it from ParseIntIP (which is demonstrated above)

Why proto-based marshaling?
Not an easy decision, but one that is more maintainable while the interface still shakes out. A byte-optimized marshaling approach will be added later as an alternative.

[github-actions]

Test Results

3 506 tests  +26   3 502 ✅ +26   1m 51s ⏱️ +9s
  392 suites ± 0       4 💤 ± 0 
   30 files   ± 0       0 ❌ ± 0 

Results for commit b87f9db. ± Comparison against base commit ae0f3a3.

This pull request removes 1 and adds 27 tests. Note that renamed tests count towards both.

go.mondoo.com/cnquery/v11/llx ‑ TestRawData_Version_Result

go.mondoo.com/cnquery/v11/llx ‑ TestRawData_JSON/0.0.0.0/8
go.mondoo.com/cnquery/v11/llx ‑ TestRawData_JSON/1.2.3
go.mondoo.com/cnquery/v11/llx ‑ TestRawData_JSON/192.168.0.1/13
go.mondoo.com/cnquery/v11/llx ‑ TestRawData_JSON/2001:db8:3c4d:15::1a2f:1a2b/64
go.mondoo.com/cnquery/v11/llx ‑ TestRawData_JSON/255.255.255.255/24
go.mondoo.com/cnquery/v11/llx ‑ TestResultRawConversions
go.mondoo.com/cnquery/v11/llx ‑ TestResultRawConversions/1.2.3
go.mondoo.com/cnquery/v11/llx ‑ TestResultRawConversions/192.168.0.1/27
go.mondoo.com/cnquery/v11/llx ‑ TestSuccess/1.2.3
go.mondoo.com/cnquery/v11/llx ‑ TestSuccess/192.168.0.1/24
…

♻️ This comment has been updated with latest results.

[afiune]

Nice!

[afiune]

beautiful ✨

[afiune]

Just a question since I see in MQL we use int64 everywhere. It looks awesome but I'm curious if we are even using all of those types? 🤔

[arlimus]

yeah tbh I just went over-eager here 😁 If I'm honest, we only need int and int64, just like the other method

[afiune]

are we missing some types here? like int and others? 🤔

[afiune]

I'm guessing no, but if so, we won't ever use the other types, I think.

[arlimus]

Not at this position, because the internal values can only be these 3, ie for int it can only be an int64. Much of the backend is built around this.

[afiune]

Pretty nice, just a question about the int2ip() func.

[afiune]

Just a question since I see in MQL we use int64 everywhere. It looks awesome but I'm curious if we are even using all of those types? 🤔